Homec4science

Don't try to download diffs-of-diffs

Authored by epriestley <git@epriestley.com> on Dec 4 2013, 23:39.

Description

Don't try to download diffs-of-diffs

Summary:
Ref T1715. When the user clicks "Download Raw Diff" in Differential, we try to build a diff of exactly what they're seeing. However:

  • This doesn't work if any of the changes have multiple hunks, and fixing it seems hard.
  • I suspect this diff is never actually useful anyway? And probably kind of confusing in the best case. You can't really apply it to anyhting, since you'd have to apply another diff first.

Instead, just build the right-side diff, which should align well with user expectation and doesn't suffer from the multi-hunk bug.

Some day, we could maybe add some of the fancy options in T1715.

See: https://github.com/facebook/phabricator/issues/461

Test Plan: Downloaded a multi-hunk diff, got the original back and applied it cleanly.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T1715

Differential Revision: https://secure.phabricator.com/D7694

Details

Committed
epriestley <git@epriestley.com>Dec 4 2013, 23:39
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb111bc039d8d: Support text-based private key credentials in DrydockSSHCommandInterface
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHff4e965c90fc: Don't try to download diffs-of-diffs (authored by epriestley <git@epriestley.com>).Dec 4 2013, 23:39