Homec4science

Extend LiskMigrationIterator from PhutilBufferedIterator

Authored by epriestley <git@epriestley.com> on Jul 26 2012, 21:01.

Description

Extend LiskMigrationIterator from PhutilBufferedIterator

Summary: PhutilBufferedIterator now implements all the nonspecific logic here.

Test Plan:
Created a test script like this:

$iterator = new LiskMigrationIterator(new DifferentialRevision());
$iterator->setPageSize(3);

foreach ($iterator as $key => $rev) {
  echo "{$key}: ".$rev->getID()."\n";
}

Ran it and verified sensible iteration results.

Reviewers: vrana, btrahan

Reviewed By: vrana

CC: aran

Maniphest Tasks: T1562

Differential Revision: https://secure.phabricator.com/D3076

Details

Committed
epriestley <git@epriestley.com>Jul 26 2012, 21:01
Pushed
aubortJan 31 2017, 17:16
Parents
rPHfc09bcf0a32a: Move qsprintf() test cases from libphutil to Phabricator
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHff61dba7acf4: Extend LiskMigrationIterator from PhutilBufferedIterator (authored by epriestley <git@epriestley.com>).Jul 26 2012, 21:01