Homec4science

Fix a fatal on the application list

Authored by epriestley <git@epriestley.com> on Apr 13 2015, 23:51.

Description

Fix a fatal on the application list

Summary:
Fixes T7816. This just punts adding proper cursor-based paging to Applications for now, since they don't have a handy order.

If we get to 101, we can either fix this properly or change the SearchEngine to return 200 results.

(Previously, we generated a cursor only if we absolutely needed to, so this code wasn't called. We generate cursors in some cases where we may not need them now, but the code is simpler this way.)

Test Plan: /applications/ no longer fatals.

Reviewers: chad, btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7816

Differential Revision: https://secure.phabricator.com/D12403

Details

Committed
epriestley <git@epriestley.com>Apr 13 2015, 23:51
Pushed
aubortJan 31 2017, 17:16
Parents
rPH281bdf87cf63: Fix a fatal for 404s in Phriction
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHff7215f3d631: Fix a fatal on the application list (authored by epriestley <git@epriestley.com>).Apr 13 2015, 23:51