Homec4science

Fix Manders' split coefficients wrong channel check bug

Authored by daniel j. white <dan@chalkie.org.uk> on Aug 30 2015, 15:28.

Description

Fix Manders' split coefficients wrong channel check bug

Manders' split coefficients were calculated correctly for the
ThresoldType.none case - we see if the pixel is above thresold (zero)
in the OTHER channel .

However, for the .Aboive and .Below thresholdType cases, we were
checking if the pixel was above or below threshold in the SAME image
channel - that's wrong.

Now we check the correct channel, the other one.
As defined by Manders in the original article.
See coloc 2 wiki page.

This bug probably had a small impact as the thresholds of the two
channels tend to be rather similar and quite low. The results wont
change much in the majority of situations. Only when the thresholds are
very different will be bug be very obvious.

Signed-off-by: daniel j. white <dan@chalkie.org.uk>

Details

Committed
daniel j. white <dan@chalkie.org.uk>Aug 30 2015, 15:28
Pushed
oburriMar 8 2018, 18:06
Parents
R6269:56656007f1a2: Merge pull request #5 from tomka/add-costes-auto-threshold-alternative
Branches
Unknown
Tags
Unknown

Event Timeline

daniel j. white <dan@chalkie.org.uk> committed R6269:e4a3a6ec36e0: Fix Manders' split coefficients wrong channel check bug (authored by daniel j. white <dan@chalkie.org.uk>).Aug 30 2015, 15:28