Homec4science

Fixed bug resulting in duplicate field names in commit messages

Authored by mgummelt <mgummelt@fb.com> on Jul 7 2011, 23:51.

Description

Fixed bug resulting in duplicate field names in commit messages

Summary:
My earlier diff refactored some code without completely
respecting the semantics, sometimes resulting in duplicate field names
returned from differential.getcommitmessage. This fixes that.

Test Plan:
ran "arc diff" with diff causing the bug (commit message
had an empty Revert Plan: field) and verified no duplicate fields

Reviewed By: epriestley
Reviewers: epriestley
CC: aran, dpepper, epriestley
Differential Revision: 610

Details

Committed
mgummelt <mgummelt@fb.com>Jul 8 2011, 00:26
Pushed
aubortJan 31 2017, 17:16
Parents
rPH3c785cdb5a9b: include task ids in the commit messages returned by "arc amend"
Branches
Unknown
Tags
Unknown

Event Timeline

mgummelt <mgummelt@fb.com> committed rPH00f4c37ca28e: Fixed bug resulting in duplicate field names in commit messages (authored by mgummelt <mgummelt@fb.com>).Jul 8 2011, 00:26