Homec4science

Mark questionable column nullability for later

Authored by epriestley <git@epriestley.com> on Oct 1 2014, 16:59.

Description

Mark questionable column nullability for later

Summary:
Ref T1191. Ref T6203. While generating expected schemata, I ran into these columns which seem to have sketchy nullability.

  • Mark most of them for later resolution (T6203). They work fine today and don't need to block T1191. Changing them can break the application, so we can't autofix them.
  • Forgive a couple of them that are sort-of reasonable or going to get wiped out.

Test Plan: Saw 94 remaining warnings.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: hach-que, epriestley

Maniphest Tasks: T1191, T6203

Differential Revision: https://secure.phabricator.com/D10593

Details

Committed
epriestley <git@epriestley.com>Oct 1 2014, 16:59
Pushed
aubortJan 31 2017, 17:16
Parents
rPH4f87adc43846: Ignore keys with trailing index on table primary key for now
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH03519c53bbcc: Mark questionable column nullability for later (authored by epriestley <git@epriestley.com>).Oct 1 2014, 16:59