Homec4science

Fix stupid error in Lisk introduced in D990

Authored by Nicholas Harper <nharper@fb.com> on Oct 8 2011, 00:56.

Description

Fix stupid error in Lisk introduced in D990

Summary:
I added some type checks in D990 to make sure $columns is an array, but was
overzealous and forgot that loadRawDataWhere needs to be able to take null
as $columns.

Test Plan:
Loaded phabricator and saw the error "Argument 1 passed to LiskDAO::loadRawDataWhere() must be an instance of array, null given" go away

Reviewers: epriestley

CC:

Differential Revision: 991

Details

Committed
Nicholas Harper <nharper@fb.com>Oct 8 2011, 00:59
Pushed
aubortJan 31 2017, 17:16
Parents
rPH872ac17dbca5: Selectively load columns for differential typeahead
Branches
Unknown
Tags
Unknown

Event Timeline

Nicholas Harper <nharper@fb.com> committed rPH05b73f58aea2: Fix stupid error in Lisk introduced in D990 (authored by Nicholas Harper <nharper@fb.com>).Oct 8 2011, 00:59