Homec4science

Remove redundant administrator requirement from application edit policy page

Authored by epriestley <git@epriestley.com> on Mar 23 2015, 17:10.

Description

Remove redundant administrator requirement from application edit policy page

Summary:
Fixes T7485. Before applications had proper policies, we gated access by requiring the viewer be an administrator.

This is now redundant (CAN_EDIT on applications has the same effect, and performs the same check), and may some day be wrong (we might let administrators configure a different policy to control who can configure applications). Today, it gets the policy dialog wrong.

Test Plan:
Clicked "Edit Policies" as a non-administrator, was unable to, got nice error:

{F346598}

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7485

Differential Revision: https://secure.phabricator.com/D12125

Details

Committed
epriestley <git@epriestley.com>Mar 23 2015, 17:10
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc7dc59f9c403: Don't call flush() when emitting responses
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH08aefafef75a: Remove redundant administrator requirement from application edit policy page (authored by epriestley <git@epriestley.com>).Mar 23 2015, 17:10