Homec4science

Default new reviewers to "added", and don't overwrite reviewer states when…

Authored by epriestley <git@epriestley.com> on Mar 12 2014, 01:12.

Description

Default new reviewers to "added", and don't overwrite reviewer states when updating

Summary:
Fixes two issues with Differential:

  • New reviewers on initial diff were being created into a null state.
  • The "=" edge update was overwriting accepted/rejected statuses. This could maybe be more nuanced in the long run, but I've just made it update correctly for now.

Test Plan:

  • Created and updated a revision, paying attention to reviewer statuses.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: aran, epriestley

Differential Revision: https://secure.phabricator.com/D8494

Details

Committed
epriestley <git@epriestley.com>Mar 12 2014, 01:12
Pushed
aubortJan 31 2017, 17:16
Parents
rPHad88ff28a1b5: Reject Phame domains which include a port number
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH0b6c0c135f84: Default new reviewers to "added", and don't overwrite reviewer states when… (authored by epriestley <git@epriestley.com>).Mar 12 2014, 01:12