Homec4science

Don't set mustcapture for falsey values

Authored by epriestley <git@epriestley.com> on Oct 17 2012, 17:35.

Description

Don't set mustcapture for falsey values

Summary: See discussion in D3722. Good catch -- I'd definitely say this is a bug.

Test Plan: Rendered two <div />s, one with mustcapture set to true and one to false. The first got data-mustcapture; the second did not.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D3723

Details

Committed
epriestley <git@epriestley.com>Oct 17 2012, 17:35
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb986f9f73107: Restore a more surgical workflow/target check
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH1105cfc3a809: Don't set mustcapture for falsey values (authored by epriestley <git@epriestley.com>).Oct 17 2012, 17:35