Homec4science

Herald - make herald condition of herald rule display better

Authored by Bob Trahan <bob.trahan@gmail.com> on Feb 10 2014, 23:40.

Description

Herald - make herald condition of herald rule display better

Summary: ...by the surprising step of changing how this data is stored from id to phid. Also a small fix to not allow "disabled" rules to be used as herald rule conditions, i.e. can't make a rule that depends on a disabled rule.

Test Plan: viewed existing herald rule that had a rule condition and noted nice new display using handle. made a new rule that had a rule condition and verified it worked correctly.

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D8186

Details

Committed
Bob Trahan <bob.trahan@gmail.com>Feb 10 2014, 23:40
Pushed
aubortJan 31 2017, 17:16
Parents
rPHfb9b023fbaaf: Rebuild custom field indexes when rebuilding standard/fulltext search indexes
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <bob.trahan@gmail.com> committed rPH183086800773: Herald - make herald condition of herald rule display better (authored by Bob Trahan <bob.trahan@gmail.com>).Feb 10 2014, 23:40