Formalize configuration sources and source stacks
19b2c3d3d00f
Actions

Authored by epriestley <git@epriestley.com> on Dec 25 2012, 15:44.

Description

Formalize configuration sources and source stacks

Summary: Currently, we have a configuration stack for unit tests, but they're built in to PhabricatorEnv. Pull them out and formalize them, so we can add more configuration sources (e.g., database).

Test Plan: Ran unit tests, web requests, scripts. This code had fairly good existing test coverage.

Reviewers: btrahan, vrana

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2223, T2221

Differential Revision: https://secure.phabricator.com/D4284

Details

Committed

epriestley <git@epriestley.com>

Dec 25 2012, 15:44

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPH3eb370a5331e: Share more HTTPSink code

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH19b2c3d3d00f: Formalize configuration sources and source stacks (authored by epriestley <git@epriestley.com>).Dec 25 2012, 15:44

Changes (14)

		Path
M		src/__phutil_library_map__.php
V		src/infrastructure/{ → env}/PhabricatorEnv.php
V		src/infrastructure/{ → env}/PhabricatorScopedEnv.php
V		src/infrastructure/{ → env}/__tests__/PhabricatorEnvTestCase.php
A	(dir)	src/infrastructure/env/
A		src/infrastructure/env/PhabricatorConfigDictionarySource.php
A		src/infrastructure/env/PhabricatorConfigFileSource.php
A		src/infrastructure/env/PhabricatorConfigProxySource.php
A		src/infrastructure/env/PhabricatorConfigSource.php
A		src/infrastructure/env/PhabricatorConfigStackSource.php
V		src/infrastructure/{env ← }/PhabricatorEnv.php
V		src/infrastructure/{env ← }/PhabricatorScopedEnv.php
A	(dir)	src/infrastructure/env/__tests__/
V		src/infrastructure/{env ← }/__tests__/PhabricatorEnvTestCase.php