Homec4science

Move project slug normalization inside project Query

Authored by epriestley <git@epriestley.com> on Dec 27 2015, 11:28.

Description

Move project slug normalization inside project Query

Summary:
Ref T10010. We currently require withSlugs() to have properly formatted slugs, but this leads to similar code in several places.

Instead: accept any slug, normalize slugs in the query, return a map so callers can figure out what happened if they want.

This tends to do the right thing by default, while keeping enough information around to do more complex things if necessary. A similar approach for querying commits has worked well in Diffusion.

Test Plan: Added and executed unit tests.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10010

Differential Revision: https://secure.phabricator.com/D14888

Details

Committed
epriestley <git@epriestley.com>Dec 27 2015, 18:20
Pushed
aubortJan 31 2017, 17:16
Parents
rPHaa2089ba6804: Support field previews in EditEngine
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH211a6c0d55f3: Move project slug normalization inside project Query (authored by epriestley <git@epriestley.com>).Dec 27 2015, 18:20