Conpherence - introduce ConpherenceThreadManager
2373185e9b62
Actions

Authored by Bob Trahan <btrahan@phacility.com> on Mar 10 2015, 20:20.

Description

Conpherence - introduce ConpherenceThreadManager

Summary:
Ref T7014. Fixes T7473. This adds a class to handle thread state about what thread is loaded and what transaction we've seen last. It is deployed 100% in the durable column and only partially deployed in the regular view. Future diff(s) should clean up regular view. Note ConpherenceThreadManager API might change a bit at that time.

Also includes a bonus bug fix so logged out users can't toggle this column

Test Plan: tried to use durable column while logged out and nothing happened. sent messages, aphlict-received messages, added people, and changed title from both views

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7473, T7014

Differential Revision: https://secure.phabricator.com/D12029

Details

Committed

Bob Trahan <btrahan@phacility.com>

Mar 10 2015, 20:20

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPHdd501117e80c: When deleting inline comments, offer "undo" instead of prompting

Branches

Unknown

Tags

Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPH2373185e9b62: Conpherence - introduce ConpherenceThreadManager (authored by Bob Trahan <btrahan@phacility.com>).Mar 10 2015, 20:20

Changes (8)

				Path
	M			resources/celerity/map.php
	M			src/applications/conpherence/controller/ConpherenceViewController.php
	M			src/view/page/PhabricatorStandardPageView.php
	A			webroot/rsrc/js/application/conpherence/ConpherenceThreadManager.js
	M			webroot/rsrc/js/application/conpherence/behavior-durable-column.js
	M			webroot/rsrc/js/application/conpherence/behavior-menu.js
	M			webroot/rsrc/js/application/conpherence/behavior-pontificate.js
	M			webroot/rsrc/js/application/conpherence/behavior-widget-pane.js