Homec4science

Diffusion / Herald - tweak "Accepted Differential Revision exists" Herald field

Authored by Bob Trahan <btrahan@phacility.com> on Sep 4 2014, 00:28.

Description

Diffusion / Herald - tweak "Accepted Differential Revision exists" Herald field

Summary: make it use the value of the revision before any post-commit magic has occurred. Fixes T4754

Test Plan: made a herald rule that said "if revision exists, and revision accept does not exists, block push". tried to push a commit that had a revision that wasn't accepted and I was blocked.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: mbishopim3, epriestley, Korvin

Maniphest Tasks: T4754, T4574

Differential Revision: https://secure.phabricator.com/D10393

Details

Committed
Bob Trahan <btrahan@phacility.com>Sep 4 2014, 00:28
Pushed
aubortJan 31 2017, 17:16
Parents
rPH7ecbc707846f: Daemons - handle daemons that can't be killed a bit better
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPH2f4addc67113: Diffusion / Herald - tweak "Accepted Differential Revision exists" Herald field (authored by Bob Trahan <btrahan@phacility.com>).Sep 4 2014, 00:28