Homec4science

Dramatically limit the range of failures which can cause duplicate mail

Authored by epriestley <git@epriestley.com> on Jun 17 2015, 01:43.

Description

Dramatically limit the range of failures which can cause duplicate mail

Summary:
Ref T8574. Currently, failures during mail body construction, feed publishing, or search indexing could cause us to retry the publishing task and potentially send duplicate mail.

Instead, build (but do not send) the mail first, then send all the mail at the very end.

This isn't completley perfect, but should make it enormously harder for duplicate mail to be generated.

Test Plan: Sent some mail, ran the daemons, saw it show up normally in the outbound queue.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8574

Differential Revision: https://secure.phabricator.com/D13320

Details

Committed
epriestley <git@epriestley.com>Jun 17 2015, 01:43
Pushed
aubortJan 31 2017, 17:16
Parents
rPHbb7f2ea9055c: Fail gracefully on bad API call when building commit mail
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH30c4783c426f: Dramatically limit the range of failures which can cause duplicate mail (authored by epriestley <git@epriestley.com>).Jun 17 2015, 01:43