Homec4science

Avoid warning in checking config classes in setup

Authored by vrana <jakubv@fb.com> on Mar 30 2012, 13:14.

Description

Avoid warning in checking config classes in setup

Summary:
Current code emits warning for classes with constructors with parameters.
It also creates the objects which is bad if constructors do some actual work.

Test Plan:
Run setup with:

  • correct classes
  • not-existing class
  • class with private constructor
  • class not implementing the required class

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D2056

Details

Committed
vrana <jakubv@fb.com>Mar 30 2012, 19:16
Pushed
aubortJan 31 2017, 17:16
Parents
rPH62053a39e373: Don't add author and reviewers to CCs in Herald
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPH3c19e5b133b7: Avoid warning in checking config classes in setup (authored by vrana <jakubv@fb.com>).Mar 30 2012, 19:16