Homec4science

Validate commit message fields on the server side

Authored by epriestley <git@epriestley.com> on Dec 2 2011, 00:43.

Description

Validate commit message fields on the server side

Summary:
See T643. We have some hard-coded checks in Arcanist for the existence of
'testPlan' and 'title', and don't properly validate those fields on the server.
Add a validation pass in the Conduit-based edit pathway.

In particular, this means that if you disable the "Test Plan" field, Arcanist
won't block you anymore.

Test Plan: Disabled Arcanist checks and ran "arc diff"; got blocked on the
server side.

Reviewers: btrahan, jungejason

Reviewed By: btrahan

CC: aran, btrahan

Differential Revision: 1153

Details

Committed
epriestley <git@epriestley.com>Dec 2 2011, 16:28
Pushed
aubortJan 31 2017, 17:16
Parents
rPHcfaab709df37: Ignore right mouse button in click on a line number in diff
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH40221feed962: Validate commit message fields on the server side (authored by epriestley <git@epriestley.com>).Dec 2 2011, 16:28