Homec4science

Split Diffusion "view" preference into blame and color preferences

Authored by epriestley <git@epriestley.com> on Sep 20 2013, 01:01.

Description

Split Diffusion "view" preference into blame and color preferences

Summary:
We have this silly "view" preference which has a variety of silly values: "plain", "plainblame", "highlighted", and "blame", and then also "raw", which is magical. This is really just two flags: color on/off, and blame on/off (plus a separate mode for raw).

Express the code in terms of the flags and, e.g., get rid of the state transition tables we had before.

Test Plan: Viewed code in all four modes.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D7046

Details

Committed
epriestley <git@epriestley.com>Sep 20 2013, 01:01
Pushed
aubortJan 31 2017, 17:16
Parents
rPH0139fb9178a7: Improve organization of Diffusion browse controllers
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH424f7545fc24: Split Diffusion "view" preference into blame and color preferences (authored by epriestley <git@epriestley.com>).Sep 20 2013, 01:01