Homec4science

Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer…

Authored by epriestley <git@epriestley.com> on Mar 10 2012, 00:46.

Description

Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code

Summary:

  • We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab.
  • Add placeholder support.
  • Augment server-side stuff to specify placeholder text.

Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, epriestley

Maniphest Tasks: T772, T946

Differential Revision: https://secure.phabricator.com/D1844

Details

Committed
epriestley <git@epriestley.com>Mar 10 2012, 00:46
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb2890eeb0e6f: Add "final" to all Phabricator "Controller" classes
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH43bd76336c6a: Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer… (authored by epriestley <git@epriestley.com>).Mar 10 2012, 00:46