Homec4science

Attempt to make dropdown item actions more consistent

Authored by epriestley <git@epriestley.com> on Jan 18 2017, 20:17.

Description

Attempt to make dropdown item actions more consistent

Summary:
See D17210. Currently, this handler needs to be installed on each menu that doesn't build with the default behavior.

Rather than copy-pasting it to the user menu, try to make it a default behavior. This adds a new rule: don't close the menu if the item is a dynamic item built in JS with PHUIXActionView.

This allows dynamic items to control the menu themselves, while giving static items the desired default behavior.

Test Plan:

  • Opened menus on: dashboards, user menu, timeline comments. Clicked stuff. Menus went away.
  • Other menus still seemed to work right: Diffusion, Favorites, mobile menu.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D17222

Details

Committed
epriestley <git@epriestley.com>Jan 18 2017, 22:14
Pushed
aubortJan 31 2017, 17:16
Parents
rPH90258ed491d5: Fix property shadowing on ActionListView after conversion to TagView
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH45c3aaeb269e: Attempt to make dropdown item actions more consistent (authored by epriestley <git@epriestley.com>).Jan 18 2017, 22:14