Homec4science

Make ManiphestTaskQuery more modern and safe

Authored by epriestley <git@epriestley.com> on Jun 22 2015, 20:54.

Description

Make ManiphestTaskQuery more modern and safe

Summary: Ref T8637. This class has some really old parameter handling which can send withIDs(array()) down a "fetch everything" pathway. Clean up most of it.

Test Plan: Issued every ApplicationSearch query.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8637

Differential Revision: https://secure.phabricator.com/D13390

Details

Committed
epriestley <git@epriestley.com>Jun 22 2015, 20:54
Pushed
aubortJan 31 2017, 17:16
Parents
rPH0597aba33ec1: Add hard stops on empty batch edit sets
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH487e12101aba: Make ManiphestTaskQuery more modern and safe (authored by epriestley <git@epriestley.com>).Jun 22 2015, 20:54