Diffusion Phabricator 495cb7a2e037

Mark `PhabricatorPHIDType::getPHIDTypeApplicationClass()` as abstract
495cb7a2e037
Actions

Authored by Joshua Spence <josh@freelancer.com> on Nov 2 2015, 11:33.

Description

Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract

Summary: Fixes T9625. As explained in a TODO comment, seems reasonable enough.

Test Plan: Unit tests.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, hach-que

Maniphest Tasks: T9625

Differential Revision: https://secure.phabricator.com/D14068

Details

Committed

Joshua Spence <josh@freelancer.com>

Nov 2 2015, 20:47

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPH09d4ea884fe4: Ref T8989, Add a "Visit URL" link to Phurl items.

Branches

Unknown

Tags

Unknown

Event Timeline

Joshua Spence <josh@freelancer.com> committed rPH495cb7a2e037: Mark `PhabricatorPHIDType::getPHIDTypeApplicationClass()` as abstract (authored by Joshua Spence <josh@freelancer.com>).Nov 2 2015, 20:47

Changes (84)

				Path
	M			src/applications/almanac/phid/AlmanacBindingPHIDType.php
	M			src/applications/almanac/phid/AlmanacDevicePHIDType.php
	M			src/applications/almanac/phid/AlmanacInterfacePHIDType.php
	M			src/applications/almanac/phid/AlmanacNetworkPHIDType.php
	M			src/applications/almanac/phid/AlmanacServicePHIDType.php
	M			src/applications/auth/phid/PhabricatorAuthAuthFactorPHIDType.php
	M			src/applications/auth/phid/PhabricatorAuthAuthProviderPHIDType.php
	M			src/applications/auth/phid/PhabricatorAuthInvitePHIDType.php
	M			src/applications/calendar/phid/PhabricatorCalendarEventPHIDType.php
	M			src/applications/config/phid/PhabricatorConfigConfigPHIDType.php
	M			src/applications/countdown/phid/PhabricatorCountdownCountdownPHIDType.php
	M			src/applications/dashboard/phid/PhabricatorDashboardDashboardPHIDType.php
	M			src/applications/dashboard/phid/PhabricatorDashboardPanelPHIDType.php
	M			src/applications/differential/phid/DifferentialDiffPHIDType.php
	M			src/applications/differential/phid/DifferentialRevisionPHIDType.php
	M			src/applications/drydock/phid/DrydockAuthorizationPHIDType.php
	M			src/applications/drydock/phid/DrydockBlueprintPHIDType.php
	M			src/applications/drydock/phid/DrydockLeasePHIDType.php
	M			src/applications/drydock/phid/DrydockRepositoryOperationPHIDType.php
	M			src/applications/drydock/phid/DrydockResourcePHIDType.php
	M			src/applications/files/phid/PhabricatorFileFilePHIDType.php
	M			src/applications/fund/phid/FundBackerPHIDType.php
	M			src/applications/harbormaster/phid/HarbormasterBuildArtifactPHIDType.php
	M			src/applications/harbormaster/phid/HarbormasterBuildLogPHIDType.php
	M			src/applications/harbormaster/phid/HarbormasterBuildPHIDType.php
	M			src/applications/harbormaster/phid/HarbormasterBuildPlanPHIDType.php
	M			src/applications/harbormaster/phid/HarbormasterBuildStepPHIDType.php
	M			src/applications/harbormaster/phid/HarbormasterBuildTargetPHIDType.php
	M			src/applications/harbormaster/phid/HarbormasterBuildablePHIDType.php
	M			src/applications/herald/phid/HeraldRulePHIDType.php
	M			src/applications/legalpad/phid/PhabricatorLegalpadDocumentPHIDType.php
	M			src/applications/maniphest/phid/ManiphestTaskPHIDType.php
	M			src/applications/meta/phid/PhabricatorApplicationApplicationPHIDType.php
	M			src/applications/metamta/phid/PhabricatorMetaMTAMailPHIDType.php
	M			src/applications/nuance/phid/NuanceItemPHIDType.php
	M			src/applications/nuance/phid/NuanceQueuePHIDType.php
	M			src/applications/nuance/phid/NuanceRequestorPHIDType.php
	M			src/applications/nuance/phid/NuanceSourcePHIDType.php
	M			src/applications/oauthserver/phid/PhabricatorOAuthServerClientAuthorizationPHIDType.php
	M			src/applications/oauthserver/phid/PhabricatorOAuthServerClientPHIDType.php
	M			src/applications/owners/phid/PhabricatorOwnersPackagePHIDType.php
	M			src/applications/paste/phid/PhabricatorPastePastePHIDType.php
	M			src/applications/people/phid/PhabricatorPeopleExternalPHIDType.php
	M			src/applications/people/phid/PhabricatorPeopleUserPHIDType.php
	M			src/applications/phame/phid/PhabricatorPhameBlogPHIDType.php
	M			src/applications/phame/phid/PhabricatorPhamePostPHIDType.php
	M			src/applications/phid/PhabricatorMetaMTAApplicationEmailPHIDType.php
	M			src/applications/phid/type/PhabricatorPHIDType.php
	M			src/applications/phid/type/__tests__/PhabricatorPHIDTypeTestCase.php
	M			src/applications/phlux/phid/PhluxVariablePHIDType.php
	M			src/applications/pholio/phid/PholioImagePHIDType.php
	M			src/applications/pholio/phid/PholioMockPHIDType.php
	M			src/applications/phortune/phid/PhortuneAccountPHIDType.php
	M			src/applications/phortune/phid/PhortuneCartPHIDType.php
	M			src/applications/phortune/phid/PhortuneChargePHIDType.php
	M			src/applications/phortune/phid/PhortuneMerchantPHIDType.php
	M			src/applications/phortune/phid/PhortunePaymentMethodPHIDType.php
	M			src/applications/phortune/phid/PhortunePaymentProviderPHIDType.php
	M			src/applications/phortune/phid/PhortuneProductPHIDType.php
	M			src/applications/phortune/phid/PhortunePurchasePHIDType.php
	M			src/applications/phortune/phid/PhortuneSubscriptionPHIDType.php
	M			src/applications/phragment/phid/PhragmentFragmentPHIDType.php
	M			src/applications/phragment/phid/PhragmentFragmentVersionPHIDType.php
	M			src/applications/phragment/phid/PhragmentSnapshotPHIDType.php
	M			src/applications/phriction/phid/PhrictionDocumentPHIDType.php
	M			src/applications/phurl/phid/PhabricatorPhurlURLPHIDType.php
	M			src/applications/policy/phid/PhabricatorPolicyPHIDTypePolicy.php
	M			src/applications/ponder/phid/PonderQuestionPHIDType.php
	M			src/applications/project/phid/PhabricatorProjectColumnPHIDType.php
	M			src/applications/project/phid/PhabricatorProjectProjectPHIDType.php
	M			src/applications/releeph/phid/ReleephBranchPHIDType.php
	M			src/applications/releeph/phid/ReleephProductPHIDType.php
	M			src/applications/releeph/phid/ReleephRequestPHIDType.php
	M			src/applications/repository/phid/PhabricatorRepositoryCommitPHIDType.php
	M			src/applications/repository/phid/PhabricatorRepositoryMirrorPHIDType.php
	M			src/applications/repository/phid/PhabricatorRepositoryPushEventPHIDType.php
	M			src/applications/repository/phid/PhabricatorRepositoryPushLogPHIDType.php
	M			src/applications/repository/phid/PhabricatorRepositoryRepositoryPHIDType.php
	M			src/applications/slowvote/phid/PhabricatorSlowvotePollPHIDType.php
	M			src/applications/spaces/phid/PhabricatorSpacesNamespacePHIDType.php
	M			src/applications/tokens/phid/PhabricatorTokenTokenPHIDType.php
	M			src/applications/transactions/phid/PhabricatorApplicationTransactionTransactionPHIDType.php
	M			src/infrastructure/daemon/workers/phid/PhabricatorWorkerBulkJobPHIDType.php
	M			src/infrastructure/daemon/workers/phid/PhabricatorWorkerTriggerPHIDType.php