Homec4science

When a commit has a "rewritten" hint, show it in the UI instead of the generic…

Authored by epriestley <git@epriestley.com> on Aug 24 2016, 14:55.

Description

When a commit has a "rewritten" hint, show it in the UI instead of the generic "deleted" message

Summary:
Ref T11522. When a commit is no longer reachable from any branch/tag, we currently show a "this has been deleted" message.

Instead, go further: check if there is a "rewritten" hint pointing at a commit the current commit was rewritten into. If we find one, show a message about that instead.

(This isn't super pretty, just getting it working for now. I expect to revisit this UI in T9713 if we don't get to it before that.)

Test Plan: {F1780703}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11522

Differential Revision: https://secure.phabricator.com/D16436

Details

Committed
epriestley <git@epriestley.com>Aug 24 2016, 18:33
Pushed
aubortJan 31 2017, 17:16
Parents
rPHe4c4724afd6b: Migrate the "badcommit" table to use the less-hacky "hint" mechanism
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH498fb331038c: When a commit has a "rewritten" hint, show it in the UI instead of the generic… (authored by epriestley <git@epriestley.com>).Aug 24 2016, 18:33