Homec4science

Remove overbearing policy checks in Phame

Authored by epriestley <git@epriestley.com> on Sep 5 2016, 20:50.

Description

Remove overbearing policy checks in Phame

Summary:
Fixes T11584. This controller does unnecessary CAN_EDIT policy checks.

These checks are enforced by EditEngine, and you can make certain types of edits (including comments) even without full-blown edit permission.

Test Plan:

  • Commented as a user without edit permission.
  • Tried to edit as a user without edit permission, was rebuffed with a policy dialog.
  • Edited as a user with edit permission.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11584

Differential Revision: https://secure.phabricator.com/D16493

Details

Committed
epriestley <git@epriestley.com>Sep 5 2016, 21:10
Pushed
aubortJan 31 2017, 17:16
Parents
rPH4dc37bcee080: Ignore repository versions on inactive devices in "Repository Servers" panel in…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH4b6da9735ba7: Remove overbearing policy checks in Phame (authored by epriestley <git@epriestley.com>).Sep 5 2016, 21:10