Homec4science

Fix alternate filtering conditions in object selector dialog

Authored by epriestley <git@epriestley.com> on Feb 11 2014, 16:45.

Description

Fix alternate filtering conditions in object selector dialog

Summary:
These didn't get updated either when the main search got rebuilt. Adjust and modernize them. Also this uses "exclude", which I couldn't find any callsites for but just missed, so restore that.

At some point I plan to swap this whole thing to ApplicationSearch and that will let us get rid of a bunch of stuff.

Test Plan: Searched for all filters, got sensible results, verified source object doesn't show up as a result.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, mbishopim3

Differential Revision: https://secure.phabricator.com/D8188

Details

Committed
epriestley <git@epriestley.com>Feb 11 2014, 16:45
Pushed
aubortJan 31 2017, 17:16
Parents
rPH094922bcb930: Support "only the first time" in Maniphest
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH4e70664ed4fa: Fix alternate filtering conditions in object selector dialog (authored by epriestley <git@epriestley.com>).Feb 11 2014, 16:45