Homec4science

Convert SavedQuery / NamedQuery to text, not bytes

Authored by epriestley <git@epriestley.com> on Oct 1 2014, 19:11.

Description

Convert SavedQuery / NamedQuery to text, not bytes

Summary: Ref T1191. Similar issue to D10613. This column usually has a hash exactly 12 bytes long, but sometimes stores an internal builtin query name like "open", "all", etc. It might be nice to promote those to 12-byte hashes of a consistent length eventually, but for now just make this a variable-length column.

Test Plan: Ran migration, no longer saw issues with reordering builtin saved searches.

Reviewers: btrahan

Subscribers: epriestley

Maniphest Tasks: T1191

Differential Revision: https://secure.phabricator.com/D10614

Details

Committed
epriestley <git@epriestley.com>Oct 1 2014, 19:11
Pushed
aubortJan 31 2017, 17:16
Parents
rPHf881b5dd7fe8: Convert DivinerLiveSymbol to text, not bytes
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH4eb439964003: Convert SavedQuery / NamedQuery to text, not bytes (authored by epriestley <git@epriestley.com>).Oct 1 2014, 19:11