Add an explcit "Changes Planned" state for Differential
4ef87eeac832
Actions

Authored by epriestley <git@epriestley.com> on Mar 5 2014, 19:47.

Description

Add an explcit "Changes Planned" state for Differential

Summary: Ref T2222. Ref T4481. This fixes the issue where "Plan Changes" could immediately trigger a state change (e.g., back to accepted) because of state-based transitions out of the NEEDS_REVISION state.

Test Plan: Planned changes an "accepted" revision, it didn't immediately return to being accepted.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2222, T4481

Differential Revision: https://secure.phabricator.com/D8403

Details

Committed

epriestley <git@epriestley.com>

Mar 5 2014, 19:47

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPH9da6ec208111: Make updates of rejected revisions behave correctly again

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH4ef87eeac832: Add an explcit "Changes Planned" state for Differential (authored by epriestley <git@epriestley.com>).Mar 5 2014, 19:47

Changes (5)

				Path
	M			src/applications/differential/constants/DifferentialRevisionStatus.php
	M			src/applications/differential/controller/DifferentialRevisionViewController.php
	M			src/applications/differential/editor/DifferentialRevisionEditor.php
	M			src/applications/differential/editor/DifferentialTransactionEditor.php
	M			src/applications/differential/view/DifferentialRevisionListView.php