Homec4science

Allow selecting text when creating inline comment

Authored by vrana <jakubv@fb.com> on Mar 10 2012, 01:04.

Description

Allow selecting text when creating inline comment

Summary:
It is currently not possible to select source code covered by reticle when creating comment.
This diff hides reticle on mouseout from reply area.

Test Plan:
Hover inline comment, verify that reticle is displayed.
Reply, verify that reticle is displayed when mouseover reply, hidden otherwise.
Repeat for create.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1851

Details

Committed
vrana <jakubv@fb.com>Mar 15 2012, 19:02
Pushed
aubortJan 31 2017, 17:16
Parents
rPHa70466a7fd76: Don't display "Loading..." for coverage which will never load
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPH4fa9798c4a1c: Allow selecting text when creating inline comment (authored by vrana <jakubv@fb.com>).Mar 15 2012, 19:02