Homec4science

Legalpad - add signature page

Authored by Bob Trahan <bob.trahan@gmail.com> on Jul 10 2013, 20:46.

Description

Legalpad - add signature page

Summary: Fixes T3481. Sort of - this thing be very ugly. Also it assumes that you'll "always" want to sign terms. I was thinking in a future diff that should be optional as well as configurable, though it was unclear to me if either was worth pursuing... Generally very hideous as the three main elements (PHUIDocument, AphrontErrorView, and AphrontForm with an AphrontFormInset) have never really played together before.

Test Plan: agreed to some test terms. noted UI displayed nicely. reloaded and noted UI told me I had signed it already. Went to different terms and filled them out wrong and got sensical errors.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T3481

Differential Revision: https://secure.phabricator.com/D6399

Details

Committed
Bob Trahan <bob.trahan@gmail.com>Jul 10 2013, 20:46
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd467c49a66e8: Send audit emails to more users
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <bob.trahan@gmail.com> committed rPH4fb3b27f1d2a: Legalpad - add signature page (authored by Bob Trahan <bob.trahan@gmail.com>).Jul 10 2013, 20:46