Homec4science

Let requestors claim their code is picked

Authored by Edward Speyer <edward@fb.com> on May 28 2013, 17:21.

Description

Let requestors claim their code is picked

Summary:
In Releeph, ReleephRequestHeaderView will render you a "mark-manually-picked" button if (a) you are authoritative (chuckr) or (b) you are the person who created this Releeph request.

However ReleephRequestActionController, which handles these button presses, will only do something if you are (a). This patch honors your button pressing if you are (b) as well.

Test Plan: Push buttons. There's another bug in the Javascript do-stuff-without-reloading-the-page code that handles these button pushes, but I'd like to fix that separately from handling this hi-pri bug.

Reviewers: epriestley, wez

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D6036

Details

Committed
Edward Speyer <edward@fb.com>May 28 2013, 17:21
Pushed
aubortJan 31 2017, 17:16
Parents
rPH764e4574d11a: Reduce responsibilities of PhabricatorPasteSearchEngine->buildSearchForm()
Branches
Unknown
Tags
Unknown

Event Timeline

Edward Speyer <edward@fb.com> committed rPH55f8e2a5656e: Let requestors claim their code is picked (authored by Edward Speyer <edward@fb.com>).May 28 2013, 17:21