Homec4science

Fix validation of SSH keys with spaces in the comment field

Authored by epriestley <git@epriestley.com> on Jun 24 2014, 00:28.

Description

Fix validation of SSH keys with spaces in the comment field

Summary: Fixes T5449. Keys are in the form <type> <key> <comments>, where comments are optional and can have spaces.

Test Plan:
Tried these invalid keys:

  • Empty.
  • One part.
  • Invalid type.

Tried these valid keys:

  • No comment.
  • Normal comment.
  • Comment with spaces.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T5449

Differential Revision: https://secure.phabricator.com/D9701

Details

Committed
epriestley <git@epriestley.com>Jun 24 2014, 00:28
Pushed
aubortJan 31 2017, 17:16
Parents
rPHdd91732df338: Make JX.Aphlict a real singleton with a more sensible initialization order
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH5dffd8873748: Fix validation of SSH keys with spaces in the comment field (authored by epriestley <git@epriestley.com>).Jun 24 2014, 00:28