Homec4science

Fix a warning when viewing a revision not attached to a repository

Authored by epriestley <git@epriestley.com> on Apr 10 2012, 22:34.

Description

Fix a warning when viewing a revision not attached to a repository

Summary: We'll get a typehint warning on the repository if there's no repository. Check outside the method instead.

Test Plan: Loaded page, no warning.

Reviewers: btrahan, vrana, jungejason

Reviewed By: vrana

CC: aran

Differential Revision: https://secure.phabricator.com/D2194

Details

Committed
epriestley <git@epriestley.com>Apr 10 2012, 22:34
Pushed
aubortJan 31 2017, 17:16
Parents
rPHfe9ba6bc67dd: Improve DifferentialRevisionQuery and add the ability to query by arcanist…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH5f615c1e6e17: Fix a warning when viewing a revision not attached to a repository (authored by epriestley <git@epriestley.com>).Apr 10 2012, 22:34