Homec4science

Create option for differential custom fields to display warning on accept

Authored by Nick Harper <nharper@fb.com> on Mar 27 2012, 07:16.

Description

Create option for differential custom fields to display warning on accept

Summary:
This adds support to differential fields to display warnings before a revision
gets accepted. Since lint and unit are differential fields, the code for their
warnings was moved into their respective field specification classes, so there
is only one code path for warnings (lint, unit, or custom).

Test Plan:
Select 'Accept' on a revision with lint/unit warnings and see messages appear
like they used to. Change it back to 'Comment' and they go away. Repeat with
a revision without lint/unit warnings and see no warnings appear. Checked
darkconsole to see no errors due to this.

Reviewers: jungejason, epriestley, vrana

Reviewed By: epriestley

CC: aran, Koolvin

Differential Revision: https://secure.phabricator.com/D2363

Details

Committed
Nick Harper <nharper@fb.com>May 2 2012, 23:30
Pushed
aubortJan 31 2017, 17:16
Parents
rPH81dd92fcdc6e: Display Show Raw File link in Diffusion Change View
Branches
Unknown
Tags
Unknown

Event Timeline

Nick Harper <nharper@fb.com> committed rPH6039ca6fb554: Create option for differential custom fields to display warning on accept (authored by Nick Harper <nharper@fb.com>).May 2 2012, 23:30