Make buildPagingClauseFromMultipleColumns() safer
604d1409f16f
Actions

Authored by epriestley <git@epriestley.com> on Apr 12 2015, 02:39.

Description

Make buildPagingClauseFromMultipleColumns() safer

Summary: Ref T7803. Reduce the amount of code we're trusting to build SQL queries.

Test Plan:

Paged through results in Maniphest, Differential and Diffusion.
Some of the NULLable groups in Maniphest are a bit funky but this was preexisting.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7803

Committed

epriestley <git@epriestley.com>

Apr 13 2015, 20:58

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPHa43473c4b65c: Begin formalizing query orders

Branches

Unknown

Tags

Unknown

epriestley <git@epriestley.com> committed rPH604d1409f16f: Make buildPagingClauseFromMultipleColumns() safer (authored by epriestley <git@epriestley.com>).Apr 13 2015, 20:58

				Path
	M			src/applications/differential/query/DifferentialRevisionQuery.php
	M			src/applications/maniphest/query/ManiphestTaskQuery.php
	M			src/applications/repository/query/PhabricatorRepositoryQuery.php
	M			src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php