Homec4science

Make notification counts properly translatable

Authored by epriestley <git@epriestley.com> on Dec 2 2015, 20:35.

Description

Make notification counts properly translatable

Summary:
Ref T9132. When I've touched PhabricatorApplication I keep hitting this bad pht() junk.

The warning is correct, these strings are not extactable and can not be translated.

Fix it so they can be extracted and translated.

Broadly, in all cases we want to render one of these:

95 Things (for fewer than some limit)
99+ Things (when we hit the limit)

Test Plan: Looked at homepage status counts, moused over them, saw reasonable strings. Grepped for removed method.

Reviewers: chad

Reviewed By: chad

Subscribers: joshuaspence

Maniphest Tasks: T9132

Differential Revision: https://secure.phabricator.com/D14638

Details

Committed
epriestley <git@epriestley.com>Dec 3 2015, 16:06
Pushed
aubortJan 31 2017, 17:16
Parents
rPHa1c7ba6b8b29: Initial support for comments/append-edits in EditEngine
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH618cec23d8f0: Make notification counts properly translatable (authored by epriestley <git@epriestley.com>).Dec 3 2015, 16:06