Homec4science
Authored by vrana <jakubv@fb.com> on Apr 10 2012, 07:00.

Description

Fix reticle

Summary:
Now I understand that behavior-edit-inline-comments.js:174-176 and DifferentialChangesetViewController.php:72-99 need to stay in sync:

  • 1 - isOnRight equals isNewFile
  • 1/-1 - left is new, right is missing
  • 1/2 - both are new

Test Plan: Hover inline comment.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran

Maniphest Tasks: T1076

Differential Revision: https://secure.phabricator.com/D2179

Details

Committed
vrana <jakubv@fb.com>Apr 10 2012, 07:09
Pushed
aubortJan 31 2017, 17:16
Parents
rPH32f12d1f8fb7: Don't fatal when generating patch emails for diffs with binaries
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPH62a172af901c: Fix reticle (authored by vrana <jakubv@fb.com>).Apr 10 2012, 07:09