Attach HeraldRules to HeraldEffects
63f4e66b1122
Actions

Authored by epriestley <git@epriestley.com> on Apr 6 2015, 19:00.

Description

Attach HeraldRules to HeraldEffects

Summary:
Ref T7731. For no particular reason, we currently put ruleID and rulePHID on HeraldEffect objects.

Pretty much all callers need the HeraldRule objects instead, and some go to great lengths to get them.

Just attach the Rule objects.

Test Plan: Will test thoroughly after next-ish changeset.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7731

Committed

epriestley <git@epriestley.com>

Apr 6 2015, 19:00

Pushed

aubort

Jan 31 2017, 17:16

Parents

Branches

Unknown

Tags

Unknown

epriestley <git@epriestley.com> committed rPH63f4e66b1122: Attach HeraldRules to HeraldEffects (authored by epriestley <git@epriestley.com>).Apr 6 2015, 19:00

				Path
	M			src/applications/differential/editor/DifferentialDiffEditor.php
	M			src/applications/diffusion/engine/DiffusionCommitHookEngine.php
	M			src/applications/herald/adapter/HeraldAdapter.php
	M			src/applications/herald/adapter/HeraldCommitAdapter.php
	M			src/applications/herald/engine/HeraldEffect.php
	M			src/applications/herald/engine/HeraldEngine.php
	M			src/applications/herald/storage/HeraldRule.php
	M			src/applications/herald/storage/transcript/HeraldApplyTranscript.php