Homec4science

Fix two edge case issues with Differential mail tags

Authored by epriestley <git@epriestley.com> on Jan 9 2014, 19:56.

Description

Fix two edge case issues with Differential mail tags

Summary:
Via Asana. The tags on Differential mail are wrong in two cases:

  • Transactions which submit inline comments but no comment text are not labeled as "comments", but should be.
  • Non-close, non-comment transactions are not labeled at all, but should be labeled "other".

Test Plan: Submitted a no-comments, inlines-only transaction and got a message with proper X-Phabricator-Mail-Tags header.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D7912

Details

Committed
epriestley <git@epriestley.com>Jan 9 2014, 19:56
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb960c8114b50: Changed \$callsign to \$argv[1] on commit_hook.php since is undefined causing…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH68de639470f0: Fix two edge case issues with Differential mail tags (authored by epriestley <git@epriestley.com>).Jan 9 2014, 19:56