Homec4science

Don't send mail to "uninteresting" auditors

Authored by epriestley <git@epriestley.com> on May 24 2016, 02:24.

Description

Don't send mail to "uninteresting" auditors

Summary:
Fixes T11017. We add packages as "uninteresting" auditors so that we can query commits by package later.

Until recently, this didn't matter because we didn't send mail to packages. But now we do, so stop mailing them when they don't actually need to do anything.

Test Plan:

  • Made a commit to a file which was part of a package but which I owned (so it does not trigger auditing).
  • var_dump()'d mail "To:" PHIDs.
    • Before patch: included package.
    • After patch: no package.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11017

Differential Revision: https://secure.phabricator.com/D15970

Details

Committed
epriestley <git@epriestley.com>May 24 2016, 02:55
Pushed
aubortJan 31 2017, 17:16
Parents
rPHbb16a1b0e2a8: Fix a possible fatal on the first push to a cluster repository
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH74e117ae41dd: Don't send mail to "uninteresting" auditors (authored by epriestley <git@epriestley.com>).May 24 2016, 02:55