Homec4science

Improve autocomplete behavior in lists and with noncompleting results

Authored by epriestley <git@epriestley.com> on Jan 16 2016, 23:59.

Description

Improve autocomplete behavior in lists and with noncompleting results

Summary:
Ref T10163. Currently, we don't activate on indented lines, but were too aggressive about this, and would not activate on lines like - Hey, @user..., where we should.

Instead, don't activate on indented lines if there's only an indent (i.e., # probably means enumerated list).

Also, if results don't have autocompletes (rare but possible with projects missing slugs), improve behavior.

Test Plan:

  • Typed #a, got no autocomplete.
  • Missing slug thing is a pain to test locallly, #1 z z z z reproduces in production. I'll just verify it there.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10163

Differential Revision: https://secure.phabricator.com/D15040

Details

Committed
epriestley <git@epriestley.com>Jan 17 2016, 00:18
Pushed
aubortJan 31 2017, 17:16
Parents
rPH75b8d3312bbb: Hide the autocompleter intelligently when you ignore it and keep typing
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH75781dba1add: Improve autocomplete behavior in lists and with noncompleting results (authored by epriestley <git@epriestley.com>).Jan 17 2016, 00:18