Homec4science

Fix ContainsConstraints for array-valued custom field constraints in "*.search"…

Authored by epriestley <git@epriestley.com> on Sep 7 2016, 16:36.

Description

Fix ContainsConstraints for array-valued custom field constraints in "*.search" methods

Summary: Fixes T11593. We ask for a list of values when searching for custom "link" fields, but don't handle it correctly when actually construcitng a query.

Test Plan:
Added this custom field:

{
  "mycompany.target-version": {
    "name": "Target Version",
    "type": "link",
    "search": true
  }
}

Set a task to "beta". Let daemons index it. Queried for:

constraints: {
  "custom.mycompany.target-version": [
    "beta"
  ]
}

Got just one result back.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11593

Differential Revision: https://secure.phabricator.com/D16508

Details

Committed
epriestley <git@epriestley.com>Sep 7 2016, 18:08
Pushed
aubortJan 31 2017, 17:16
Parents
rPH38ae81fb3916: Throw when callers pass an invalid constraint to a "*.search" method
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH76af4d649bfc: Fix ContainsConstraints for array-valued custom field constraints in "*.search"… (authored by epriestley <git@epriestley.com>).Sep 7 2016, 18:08