Homec4science

Make logic for streaming VCS stuff directly to Files more reusable

Authored by epriestley <git@epriestley.com> on Aug 26 2016, 17:04.

Description

Make logic for streaming VCS stuff directly to Files more reusable

Summary:
Ref T11524. Ref T10423. Earlier, I converted diffusion.filecontentquery to put the actual file content in Files, then return a PHID for the file, instead of trying to send the content over Conduit.

In T11524, we have a similar set of problems with diffs that contain non-UTF8 data (and, in T10423, diffs that are simply enormous).

I want to provide an API method to do the same sort of thing with diff output (like from git diff), so we call the method, it shoves the data in Files, and then we go pull it out of Files.

To support this, take the "shove the output of a Future into Files" logic and put it in a new base FileFuture query. This will let me make RawDiffQuery share the logic more easily.

Test Plan: Browsed Diffusion, ran diffusion.filecontentquery to fetch file content.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10423, T11524

Differential Revision: https://secure.phabricator.com/D16458

Details

Committed
epriestley <git@epriestley.com>Aug 27 2016, 18:10
Pushed
aubortJan 31 2017, 17:16
Parents
rPH067d12d7168a: Converted the pinned applications selector to a typeahead.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH771579496fc1: Make logic for streaming VCS stuff directly to Files more reusable (authored by epriestley <git@epriestley.com>).Aug 27 2016, 18:10