Homec4science

Make herald tokenizers copy values more correctly

Authored by epriestley <git@epriestley.com> on Jan 21 2016, 20:08.

Description

Make herald tokenizers copy values more correctly

Summary:
Fixes T10190. This is still a touch weird (newly typed tokens lose icons when copied) but basically works correctly. Saving/editing rules is fine, just some minor display glitching.

Fixing the icon thing is a little more involved.

Test Plan: Swapped Herald tokenizer fields around saw values (approximately) preserved.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10190

Differential Revision: https://secure.phabricator.com/D15077

Details

Committed
epriestley <git@epriestley.com>Jan 21 2016, 21:17
Pushed
aubortJan 31 2017, 17:16
Parents
rPH358240b80400: Fix an issue with paginating queries which reverse vector ordering components
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH7bf4ef451b3f: Make herald tokenizers copy values more correctly (authored by epriestley <git@epriestley.com>).Jan 21 2016, 21:17