Homec4science

Fix two issues with creating Conpherence threads via mail on some configurations

Authored by epriestley <git@epriestley.com> on Dec 12 2013, 19:59.

Description

Fix two issues with creating Conpherence threads via mail on some configurations

Summary:
Ref T4107. Two issues:

  • With strict MySQL settings, we try to insert null into the non-nullable messageCount field. Add an initializeNew... method.
  • If we don't create a new conpherence (for example, because the message body is empty), we fatal on getPHID() right now.

Also, make this stuff a little easier to test.

Test Plan: Used mail_handler.php to receive empty conpherence mail, and new-thread conpherence mail.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4107

Differential Revision: https://secure.phabricator.com/D7760

Details

Committed
epriestley <git@epriestley.com>Dec 12 2013, 19:59
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd846f6508b2c: Fix some repository URI handling issues in Git and Mercurial
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH7f45824984de: Fix two issues with creating Conpherence threads via mail on some configurations (authored by epriestley <git@epriestley.com>).Dec 12 2013, 19:59