Convert commits to use unified table of contents
8149399312b0
Actions

Authored by epriestley <git@epriestley.com> on Aug 15 2015, 21:57.

Description

Convert commits to use unified table of contents

Summary:
Fixes T2183. We now use the same rendering element in both places.

Intentional changes:

Package highlighting is out, coming back to both apps in next diff.
removed redundant-feeling "Change" link. The information is now shown with a character ("M", "V", etc.) and the page is a click away under "History". Clicking the path also jumps you to substantially similar content. (We could restore it fairly easily, I just think it's probably the least useful thing in the table right now.)

Test Plan: Viewed a bunch of commits in Diffusion.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T2183

Committed

epriestley <git@epriestley.com>

Aug 15 2015, 21:57

Pushed

aubort

Jan 31 2017, 17:16

Parents

Branches

Unknown

Tags

Unknown

epriestley <git@epriestley.com> committed rPH8149399312b0: Convert commits to use unified table of contents (authored by epriestley <git@epriestley.com>).Aug 15 2015, 21:57

				Path
	M			src/__phutil_library_map__.php
	M			src/applications/differential/controller/DifferentialController.php
	M			src/applications/differential/controller/DifferentialDiffViewController.php
	M			src/applications/differential/controller/DifferentialRevisionViewController.php
	D			src/applications/differential/view/DifferentialDiffTableOfContentsView.php
	M			src/applications/diffusion/controller/DiffusionCommitController.php
	D			src/applications/diffusion/view/DiffusionCommitChangeTableView.php
	M			src/infrastructure/diff/view/PHUIDiffTableOfContentsItemView.php
	M			src/infrastructure/diff/view/PHUIDiffTableOfContentsListView.php