Homec4science

Add JIRA doorkeeper and remarkup support

Authored by epriestley <git@epriestley.com> on Sep 4 2013, 02:27.

Description

Add JIRA doorkeeper and remarkup support

Summary:
Ref T3687. Adds a Doorkeeper bridge for JIRA issues, plus remarkup support. In particular:

  • The Asana and JIRA remarkup rules shared most of their implementation, so I refactored what I could into a base class.
  • Actual bridge implementation is straightforward and similar to Asana, although probably not similar enough to really justify refactoring.

Test Plan:

  • When logged in as a JIRA-connected user, pasted a JIRA issue link and saw it enriched at rendering time.
  • Logged in and out with JIRA.
  • Tested an Asana link, too (seems I haven't broken anything).

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T3687

Differential Revision: https://secure.phabricator.com/D6878

Details

Committed
epriestley <git@epriestley.com>Sep 4 2013, 02:27
Pushed
aubortJan 31 2017, 17:16
Parents
rPHe5b4ce5525d7: Reduce the amount of OAuth1/OAuth2 code duplication for rendering login buttons
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH825fb9c85ae7: Add JIRA doorkeeper and remarkup support (authored by epriestley <git@epriestley.com>).Sep 4 2013, 02:27