Homec4science

Separate all commit message field parsing out of Differential custom fields

Authored by epriestley <git@epriestley.com> on Dec 14 2016, 17:14.

Description

Separate all commit message field parsing out of Differential custom fields

Summary:
Ref T11114. See that task for some discussion.

Overall, Differential custom fields ended up with too many responsibilities. Later work in EditEngine provides a more promising model for achieving modularity with smaller, more consistent components.

In particular, we have some custom fields like DifferentialGitSVNIDField and DifferentialConflictsField which serve only to support the field parser.

This starts pulling commit message responsibilities out of the core list of custom fields and into simpler dedicated parsers.

Test Plan: Created and edited revisions from the CLI. Added a bit of test coverage.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11114

Differential Revision: https://secure.phabricator.com/D17058

Details

Committed
epriestley <git@epriestley.com>Dec 15 2016, 03:44
Pushed
aubortJan 31 2017, 17:16
Parents
rPH552c54668988: Separate commit message parsing and validation from Conduit
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH8476ad1a281c: Separate all commit message field parsing out of Differential custom fields (authored by epriestley <git@epriestley.com>).Dec 15 2016, 03:44