Homec4science

Email Preferences - round out options for Projects and Phriction

Authored by Bob Trahan <btrahan@phacility.com> on Jun 16 2015, 23:25.

Description

Email Preferences - round out options for Projects and Phriction

Summary: Fixes T8524, T8550. These were both missing "subscribers" and Phriction was also the only application with no "other".

Test Plan:

  • Project
      • set user A to notify only for project subscriber changes
      • made a project with user A
      • subscribed user B to project
      • verified notification sent to user A
      • used ./bin/mail to make sure no mail was sent to user A because "This mail has tags which control which users receive it, and this recipient has not elected to receive mail with any of the tags on this message (Settings > Email Preferences)."
    • Phriction
      • set user A to notify only for phriction document subscriber changes
      • made a document with user A
      • subscribed user B to document
      • verified notification sent to user A
      • used ./bin/mail to make sure no mail was sent to user A because "This mail has tags which control which users receive it, and this recipient has not elected to receive mail with any of the tags on this message (Settings > Email Preferences)."
      • observed option for "other" in email preferences

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T8524, T8550

Differential Revision: https://secure.phabricator.com/D13313

Details

Committed
Bob Trahan <btrahan@phacility.com>Jun 16 2015, 23:25
Pushed
aubortJan 31 2017, 17:16
Parents
rPH6b7d7401ca6d: Modernize Diviner
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPH8965c7ec9b89: Email Preferences - round out options for Projects and Phriction (authored by Bob Trahan <btrahan@phacility.com>).Jun 16 2015, 23:25