Homec4science

Don't waste too much cache by a single changeset

Authored by vrana <jakubv@fb.com> on Aug 27 2012, 22:08.

Description

Don't waste too much cache by a single changeset

Summary:
We have max_allowed_packet 1 GiB but our replication dies if the query is longer than unknown value (it dies with 293 MB long query).

Anyway, there's no reason why we should not save the cache if you have small max_allowed_packet.

Test Plan: Lowered $size to 100, deleted cache from DB, displayed changeset, verified issued queries in DarkConsole, verified DB.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3390

Details

Committed
vrana <jakubv@fb.com>Aug 28 2012, 01:51
Pushed
aubortJan 31 2017, 17:16
Parents
rPH5f3dc3b7aecf: Make storage.mysql-engine.max-size independent on max_allowed_packet
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPH8b715a64b52d: Don't waste too much cache by a single changeset (authored by vrana <jakubv@fb.com>).Aug 28 2012, 01:51